Forward user information from GUI and coconut to Kafka for use by Bookkeeping #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Looks good, thanks.
I am only wondering if transitions to ERROR should be "signed" with the user name, since user never asks an environment to go to ERROR, it is a direct consequence of the software going wrong. In any case, I let you and the GUI teams decide what you want to see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinboulais new protofile common.proto + see changes in events.proto
@graduta new protofile common.proto + see changes in o2control.proto